Skip to content

Commit 54956df

Browse files
j6tgitster
authored andcommitted
t4130: work around Windows limitation
On Windows, it is already pretty expensive to try to recreate the stat() data that Git assumes is cheap to obtain. To make things halfway decent in performance, we even have to skip emulating the inode and to determine the number of hard links. This is not a huge problem, usually, as either the size or the mtime or the ctime are tell-tale enough to say when a file has changed, and even if not, those changes are typically made after the index file was written, triggering a rehashing of the files' contents. The t4130-apply-criss-cross-rename test case, however, requires the inode to determine that files of equal size were swapped, as renaming files does not update their mtime. Every once in a while, t4130 fails on Windows because of this missing piece. Equal file sizes are not crucial for the test cases, however. Hence, generate files with different sizes so that there is some property that the swapped files can be discovered reliably even on Windows. Helped-by: Johannes Schindelin <[email protected]> Signed-off-by: Johannes Sixt <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent e465796 commit 54956df

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

t/t4130-apply-criss-cross-rename.sh

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,13 @@ create_file() {
1313
}
1414

1515
test_expect_success 'setup' '
16-
create_file file1 "File1 contents" &&
17-
create_file file2 "File2 contents" &&
18-
create_file file3 "File3 contents" &&
16+
# Ensure that file sizes are different, because on Windows
17+
# lstat() does not discover inode numbers, and we need
18+
# other properties to discover swapped files
19+
# (mtime is not always different, either).
20+
create_file file1 "some content" &&
21+
create_file file2 "some other content" &&
22+
create_file file3 "again something else" &&
1923
git add file1 file2 file3 &&
2024
git commit -m 1
2125
'

0 commit comments

Comments
 (0)