Skip to content

Commit 5692a46

Browse files
newrengitster
authored andcommitted
merge-ort: fix accidental strset<->strintmap
Both strset_for_each_entry and strintmap_for_each_entry are macros that evaluate to the same thing, so they are technically interchangeable. However, the intent is that we use the one matching the variable type we are passing. Unfortunately, I somehow mistakenly got one of these wrong in 7bee6c1 (merge-ort: avoid recursing into directories when we don't need to, 2021-07-16) -- possibly related to the fact that relevant_sources was initially a strset and later refactored into a strintmap. Correct which macro we use. Signed-off-by: Elijah Newren <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent a373f93 commit 5692a46

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

merge-ort.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1517,8 +1517,8 @@ static int handle_deferred_entries(struct merge_options *opt,
15171517
struct strintmap copy;
15181518

15191519
/* Loop over the set of paths we need to know rename info for */
1520-
strset_for_each_entry(&renames->relevant_sources[side],
1521-
&iter, entry) {
1520+
strintmap_for_each_entry(&renames->relevant_sources[side],
1521+
&iter, entry) {
15221522
char *rename_target, *dir, *dir_marker;
15231523
struct strmap_entry *e;
15241524

0 commit comments

Comments
 (0)