Merge branch 'jk/really-deprecate-pack-redundant'

gitster · gitster · commit 5e4070e12808 · 2023-04-04T14:28:29.000-07:00
"git pack-redundant" gave a warning when run, as the command has
outlived its usefulness long ago and is nominated for future
removal.  Now we escalate to give an error.

* jk/really-deprecate-pack-redundant:
  pack-redundant: escalate deprecation warning to an error
diff --git a/builtin/pack-redundant.c b/builtin/pack-redundant.c
@@ -604,6 +604,7 @@ int cmd_pack_redundant(int argc, const char **argv, const char *prefix)
 			"option, '--i-still-use-this', on the command line\n"
 			"and let us know you still use it by sending an e-mail\n"
 			"to <git@vger.kernel.org>.  Thanks.\n"), stderr);
+		die(_("refusing to run without --i-still-use-this"));
 	}
 
 	if (load_all_packs)

Original file line number	Diff line number	Diff line change
`@@ -604,6 +604,7 @@ int cmd_pack_redundant(int argc, const char *argv, const char prefix)`
`604`	`604`	`"option, '--i-still-use-this', on the command line\n"`
`605`	`605`	`"and let us know you still use it by sending an e-mail\n"`
`606`	`606`	`"to <[email protected]>. Thanks.\n"), stderr);`
	`607`	`+ die(_("refusing to run without --i-still-use-this"));`
`607`	`608`	`}`
`608`	`609`
`609`	`610`	`if (load_all_packs)`