strbuf: make sure buffer is zero-terminated

kusma · gitster · commit 5e7a5d97f8a7 · 2011-04-11T14:10:05.000-07:00
strbuf_init does not zero-terminate the initial buffer when hint is
non-zero. Fix this so we can rely on the string to be zero-terminated
even if we haven't filled it with anything yet.

Signed-off-by: Erik Faye-Lund &lt;kusmabite@gmail.com&gt;
Acked-by: Jeff King &lt;peff@peff.net&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/strbuf.c b/strbuf.c
@@ -30,8 +30,10 @@ void strbuf_init(struct strbuf *sb, size_t hint)
 {
 	sb->alloc = sb->len = 0;
 	sb->buf = strbuf_slopbuf;
-	if (hint)
+	if (hint) {
 		strbuf_grow(sb, hint);
+		sb->buf[0] = '\0';
+	}
 }
 
 void strbuf_release(struct strbuf *sb)

Original file line number	Diff line number	Diff line change
`@@ -30,8 +30,10 @@ void strbuf_init(struct strbuf *sb, size_t hint)`
`30`	`30`	`{`
`31`	`31`	`sb->alloc = sb->len = 0;`
`32`	`32`	`sb->buf = strbuf_slopbuf;`
`33`		`- if (hint)`
	`33`	`+ if (hint) {`
`34`	`34`	`strbuf_grow(sb, hint);`
	`35`	`+ sb->buf[0] = '\0';`
	`36`	`+ }`
`35`	`37`	`}`
`36`	`38`
`37`	`39`	`void strbuf_release(struct strbuf *sb)`