Skip to content

Commit 5f4436a

Browse files
pcloudsgitster
authored andcommitted
Document update for nd/unpack-trees-with-cache-tree
Fix an incorrect comment in the new code added in b4da373 (unpack-trees: optimize walking same trees with cache-tree - 2018-08-18) and document about the new test variable that is enabled by default in test-lib.sh in 4592e60 (cache-tree: verify valid cache-tree in the test suite - 2018-08-18) Signed-off-by: Nguyễn Thái Ngọc Duy <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 4592e60 commit 5f4436a

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

t/README

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -315,6 +315,10 @@ packs on demand. This normally only happens when the object size is
315315
over 2GB. This variable forces the code path on any object larger than
316316
<n> bytes.
317317

318+
GIT_TEST_VALIDATE_INDEX_CACHE_ENTRIES=<boolean> checks that cache-tree
319+
records are valid when the index is written out or after a merge. This
320+
is mostly to catch missing invalidation. Default is true.
321+
318322
Naming Tests
319323
------------
320324

unpack-trees.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -676,8 +676,8 @@ static int index_pos_by_traverse_info(struct name_entry *names,
676676

677677
/*
678678
* Fast path if we detect that all trees are the same as cache-tree at this
679-
* path. We'll walk these trees recursively using cache-tree/index instead of
680-
* ODB since already know what these trees contain.
679+
* path. We'll walk these trees in an iterative loop using cache-tree/index
680+
* instead of ODB since we already know what these trees contain.
681681
*/
682682
static int traverse_by_cache_tree(int pos, int nr_entries, int nr_names,
683683
struct name_entry *names,

0 commit comments

Comments
 (0)