builtin/ls-remote: plug leaking server options

pks-t · gitster · commit 5f5dd8e297b5 · 2024-11-04T22:37:51.000-08:00
The list of server options populated via `OPT_STRING_LIST()` is never
cleared, causing a memory leak. Plug it.

This leak is exposed by t5702, but plugging it alone does not make the
whole test suite pass.

Signed-off-by: Patrick Steinhardt &lt;ps@pks.im&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin/ls-remote.c b/builtin/ls-remote.c
@@ -166,6 +166,7 @@ int cmd_ls_remote(int argc,
 		status = 0; /* we found something */
 	}
 
+	string_list_clear(&server_options, 0);
 	ref_sorting_release(sorting);
 	ref_array_clear(&ref_array);
 	if (transport_disconnect(transport))

Original file line number	Diff line number	Diff line change
`@@ -166,6 +166,7 @@ int cmd_ls_remote(int argc,`
`166`	`166`	`status = 0; /* we found something */`
`167`	`167`	`}`
`168`	`168`
	`169`	`+ string_list_clear(&server_options, 0);`
`169`	`170`	`ref_sorting_release(sorting);`
`170`	`171`	`ref_array_clear(&ref_array);`
`171`	`172`	`if (transport_disconnect(transport))`