Skip to content

Commit 5fe8143

Browse files
ramsay-jonesgitster
authored andcommitted
sequencer: make sign_off_header a file local symbol
Commit d0aaa46 ("commit: move empty message checks to libgit", 2017-11-10) removes the last use of 'sign_off_header' outside of the "sequencer.c" source file. Remove the extern declaration from the header file and mark the definition of the symbol with the static keyword. Signed-off-by: Ramsay Jones <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 268fbcd commit 5fe8143

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

sequencer.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131

3232
#define GIT_REFLOG_ACTION "GIT_REFLOG_ACTION"
3333

34-
const char sign_off_header[] = "Signed-off-by: ";
34+
static const char sign_off_header[] = "Signed-off-by: ";
3535
static const char cherry_picked_prefix[] = "(cherry picked from commit ";
3636

3737
GIT_PATH_FUNC(git_path_commit_editmsg, "COMMIT_EDITMSG")

sequencer.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,6 @@ int check_todo_list(void);
8383
int skip_unnecessary_picks(void);
8484
int rearrange_squash(void);
8585

86-
extern const char sign_off_header[];
87-
8886
void append_signoff(struct strbuf *msgbuf, int ignore_footer, unsigned flag);
8987
void append_conflicts_hint(struct strbuf *msgbuf);
9088
int message_is_empty(const struct strbuf *sb,

0 commit comments

Comments
 (0)