Skip to content

Commit 60f8a00

Browse files
committed
t1300: mark all test cases with funny filenames as !MINGW
On Windows, it is impossible to create a file whose name contains a quote character. We already excluded test cases using such files from running on Windows when git.exe itself was tested. However, we still had two test cases that try to create such a file, and redirect stdin from such a file, respectively. This *seems* to work in Git for Windows' Bash due to an obscure feature inherited from Cygwin: illegal filename characters are simply mapped into/from a private UTF-8 page. Pure Win32 programs (such as git.exe) *still* cannot work with those files, of course, but at least Unix shell scripts pretend to be able to. This entire strategy breaks down when switching to any Unix shell lacking support for that private UTF-8 page trick, e.g. BusyBox-w32's ash. So let's just exclude test cases that test whether the Unix shell can redirect to/from files with "funny names" those from running on Windows, too. Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 3d8b651 commit 60f8a00

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

t/t1300-config.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1710,7 +1710,7 @@ test_expect_success '--show-origin getting a single key' '
17101710
test_cmp expect output
17111711
'
17121712

1713-
test_expect_success 'set up custom config file' '
1713+
test_expect_success !MINGW 'set up custom config file' '
17141714
CUSTOM_CONFIG_FILE="file\" (dq) and spaces.conf" &&
17151715
cat >"$CUSTOM_CONFIG_FILE" <<-\EOF
17161716
[user]
@@ -1726,7 +1726,7 @@ test_expect_success !MINGW '--show-origin escape special file name characters' '
17261726
test_cmp expect output
17271727
'
17281728

1729-
test_expect_success '--show-origin stdin' '
1729+
test_expect_success !MINGW '--show-origin stdin' '
17301730
cat >expect <<-\EOF &&
17311731
standard input: user.custom=true
17321732
EOF

0 commit comments

Comments
 (0)