git-send-email.perl: ensure $domain is defined before using it

drafnel · gitster · commit 61ef5e9b56e1 · 2010-09-27T11:41:45.000-07:00
valid_fqdn() may attempt to operate on an undefined value if
Net::Domain::domainname fails to determine the domain name.  This causes
perl to emit unpleasant warnings.

So, add a check for whether $domain has been defined before using it.

Signed-off-by: Brandon Casey &lt;drafnel@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/git-send-email.perl b/git-send-email.perl
@@ -895,7 +895,7 @@ sub sanitize_address {
 
 sub valid_fqdn {
 	my $domain = shift;
-	return !($^O eq 'darwin' && $domain =~ /\.local$/) && $domain =~ /\./;
+	return defined $domain && !($^O eq 'darwin' && $domain =~ /\.local$/) && $domain =~ /\./;
 }
 
 sub maildomain_net {

Original file line number	Diff line number	Diff line change
`@@ -895,7 +895,7 @@ sub sanitize_address {`
`895`	`895`
`896`	`896`	`sub valid_fqdn {`
`897`	`897`	`my $domain = shift;`
`898`		`- return !($^O eq 'darwin' && $domain =~ /\.local$/) && $domain =~ /\./;`
	`898`	`+ return defined $domain && !($^O eq 'darwin' && $domain =~ /\.local$/) && $domain =~ /\./;`
`899`	`899`	`}`
`900`	`900`
`901`	`901`	`sub maildomain_net {`