Skip to content

Commit 6219bb2

Browse files
committed
test: turn EXPENSIVE into a lazy prerequisite
Two test scripts (t0021 and t5551) had copy & paste code to set EXPENSIVE prerequisite. Use the test_lazy_prereq helper to define them in the common t/test-lib.sh. Signed-off-by: Junio C Hamano <[email protected]>
1 parent 7bbc4e8 commit 6219bb2

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

t/t0021-conversion.sh

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -190,8 +190,6 @@ test_expect_success 'required filter clean failure' '
190190
test_must_fail git add test.fc
191191
'
192192

193-
test -n "$GIT_TEST_LONG" && test_set_prereq EXPENSIVE
194-
195193
test_expect_success EXPENSIVE 'filter large file' '
196194
git config filter.largefile.smudge cat &&
197195
git config filter.largefile.clean cat &&

t/t5551-http-fetch.sh

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -214,8 +214,6 @@ test_expect_success 'cookies stored in http.cookiefile when http.savecookies set
214214
test_cmp expect_cookies.txt cookies_tail.txt
215215
'
216216

217-
test -n "$GIT_TEST_LONG" && test_set_prereq EXPENSIVE
218-
219217
test_expect_success EXPENSIVE 'create 50,000 tags in the repo' '
220218
(
221219
cd "$HTTPD_DOCUMENT_ROOT_PATH/repo.git" &&

t/test-lib.sh

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -855,6 +855,10 @@ test_lazy_prereq AUTOIDENT '
855855
git var GIT_AUTHOR_IDENT
856856
'
857857

858+
test_lazy_prereq EXPENSIVE '
859+
test -n "$GIT_TEST_LONG"
860+
'
861+
858862
# When the tests are run as root, permission tests will report that
859863
# things are writable when they shouldn't be.
860864
test -w / || test_set_prereq SANITY

0 commit comments

Comments
 (0)