Skip to content

Commit 625e7f1

Browse files
jonathantanmygitster
authored andcommitted
promisor-remote: remove unused variable
The variable core_partial_clone_filter_default has been unused since fa3d1b6 ("promisor-remote: parse remote.*.partialclonefilter", 2019-06-25), when Git was changed to refer to remote.*.partialclonefilter as the default filter when fetching in a partial clone, but (perhaps inadvertently) there was no fallback to core.partialclonefilter. One alternative is to add the fallback, but the aforementioned change was made more than a year ago and I have not heard of any complaints regarding this matter. In addition, there is currently no mention of core.partialclonefilter in the user documentation. So it seems best to reaffirm that Git will only support remote.*.partialclonefilter. Signed-off-by: Jonathan Tan <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 385c171 commit 625e7f1

File tree

2 files changed

+1
-6
lines changed

2 files changed

+1
-6
lines changed

promisor-remote.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
#include "strvec.h"
77

88
static char *repository_format_partial_clone;
9-
static const char *core_partial_clone_filter_default;
109

1110
void set_repository_format_partial_clone(char *partial_clone)
1211
{
@@ -100,10 +99,6 @@ static int promisor_remote_config(const char *var, const char *value, void *data
10099
size_t namelen;
101100
const char *subkey;
102101

103-
if (!strcmp(var, "core.partialclonefilter"))
104-
return git_config_string(&core_partial_clone_filter_default,
105-
var, value);
106-
107102
if (parse_config_key(var, "remote", &name, &namelen, &subkey) < 0)
108103
return 0;
109104

promisor-remote.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ struct object_id;
99
* Promisor remote linked list
1010
*
1111
* Information in its fields come from remote.XXX config entries or
12-
* from extensions.partialclone or core.partialclonefilter.
12+
* from extensions.partialclone.
1313
*/
1414
struct promisor_remote {
1515
struct promisor_remote *next;

0 commit comments

Comments
 (0)