Skip to content

Commit 63642d5

Browse files
ossilatorgitster
authored andcommitted
sequencer: remove unreachable exit condition in pick_commits()
This was introduced by 56dc3ab ("sequencer (rebase -i): implement the 'edit' command", 2017-01-02), and was pointless from the get-go: all early exits from the loop above are returns, so todo_list->current == todo_list->nr is an invariant after the loop. Signed-off-by: Oswald Buddenhagen <[email protected]> Acked-by: Phillip Wood <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 43c8a30 commit 63642d5

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

sequencer.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4823,10 +4823,6 @@ static int pick_commits(struct repository *r,
48234823
struct strbuf head_ref = STRBUF_INIT, buf = STRBUF_INIT;
48244824
struct stat st;
48254825

4826-
/* Stopped in the middle, as planned? */
4827-
if (todo_list->current < todo_list->nr)
4828-
return 0;
4829-
48304826
if (read_oneliner(&head_ref, rebase_path_head_name(), 0) &&
48314827
starts_with(head_ref.buf, "refs/")) {
48324828
const char *msg;

0 commit comments

Comments
 (0)