Skip to content

Commit 63fcbe0

Browse files
paskyJunio C Hamano
authored andcommitted
gitweb: Do not use absolute font sizes
Avoid specifying font sizes in pixels, since that is just pure evil. Pointed out by Chris Riddoch. Note that this is pretty much just a proposal; I didn't test if everything fits perfectly right, but things seem to be pretty much okay. repo.or.cz uses it now as a test drive - if you find any visual quirks, please point them out, with a patch if possible since I'm total CSS noob and debugging CSS is an extremely painful experience for me. Note that this patch actually does change visual look of gitweb in Firefox with my resolution and default settings - everything is bigger and I can't explain the joy of actually seeing gitweb text that is in _readable_ size; also, my horizontal screen real estate feels better used now. But judging from the look of most modern webpages on the 'net, most people prefer reading the web with strained eyes and/or a magnifying glass (I wonder what species of scientists should look into this mystifying phenomenon) - so, please tell us what you think. Maybe we might want to get rid of absolute sizes other than font sizes in the CSS file too in the long term. Signed-off-by: Petr Baudis <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 35c49ee commit 63fcbe0

File tree

1 file changed

+9
-10
lines changed

1 file changed

+9
-10
lines changed

gitweb/gitweb.css

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
body {
22
font-family: sans-serif;
3-
font-size: 12px;
43
border: solid #d9d8d1;
54
border-width: 1px;
65
margin: 10px;
@@ -31,7 +30,7 @@ img.logo {
3130
div.page_header {
3231
height: 25px;
3332
padding: 8px;
34-
font-size: 18px;
33+
font-size: 150%;
3534
font-weight: bold;
3635
background-color: #d9d8d1;
3736
}
@@ -113,7 +112,7 @@ span.signoff {
113112

114113
div.log_link {
115114
padding: 0px 8px;
116-
font-size: 10px;
115+
font-size: 70%;
117116
font-family: sans-serif;
118117
font-style: normal;
119118
position: relative;
@@ -204,13 +203,13 @@ table.blame {
204203

205204
table.blame td {
206205
padding: 0px 5px;
207-
font-size: 12px;
206+
font-size: 100%;
208207
vertical-align: top;
209208
}
210209

211210
th {
212211
padding: 2px 5px;
213-
font-size: 12px;
212+
font-size: 100%;
214213
text-align: left;
215214
}
216215

@@ -232,14 +231,14 @@ tr.dark:hover {
232231

233232
td {
234233
padding: 2px 5px;
235-
font-size: 12px;
234+
font-size: 100%;
236235
vertical-align: top;
237236
}
238237

239238
td.link, td.selflink {
240239
padding: 2px 5px;
241240
font-family: sans-serif;
242-
font-size: 10px;
241+
font-size: 70%;
243242
}
244243

245244
td.selflink {
@@ -416,7 +415,7 @@ div.index_include {
416415
}
417416

418417
div.search {
419-
font-size: 12px;
418+
font-size: 100%;
420419
font-weight: normal;
421420
margin: 4px 8px;
422421
position: absolute;
@@ -444,7 +443,7 @@ a.rss_logo {
444443
background-color: #ff6600;
445444
font-weight: bold;
446445
font-family: sans-serif;
447-
font-size: 10px;
446+
font-size: 70%;
448447
text-align: center;
449448
text-decoration: none;
450449
}
@@ -455,7 +454,7 @@ a.rss_logo:hover {
455454

456455
span.refs span {
457456
padding: 0px 4px;
458-
font-size: 10px;
457+
font-size: 70%;
459458
font-weight: normal;
460459
border: 1px solid;
461460
background-color: #ffaaff;

0 commit comments

Comments
 (0)