Skip to content

Commit 64a5e98

Browse files
committed
t2020: test variations that matter
Because our test suite is not about validating the working of the shell, it is pointless to test variations of how a literal string 'yes' is quoted when assigned to an environment variable. Instead, test various ways to spell 'yes' (we use strcasecmp() so uppercased and capitalized variant should work just like 'yes' spelled in all lowercase) and make sure we take them as 'yes'. That is more relevant in testing Git. Signed-off-by: Junio C Hamano <[email protected]>
1 parent c2f1d39 commit 64a5e98

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

t/t2020-checkout-detach.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -294,15 +294,15 @@ test_expect_success 'describe_detached_head does print SHA-1 ellipsis when asked
294294
# Various ways of asking for ellipses...
295295
# The user can just use any kind of quoting (including none).
296296
297-
GIT_PRINT_SHA1_ELLIPSIS="yes" git -c 'core.abbrev=12' checkout HEAD^ >actual 2>&1 &&
297+
GIT_PRINT_SHA1_ELLIPSIS=yes git -c 'core.abbrev=12' checkout HEAD^ >actual 2>&1 &&
298298
check_detached &&
299299
test_i18ncmp 1st_detach actual &&
300300
301-
GIT_PRINT_SHA1_ELLIPSIS='yes' git -c 'core.abbrev=12' checkout HEAD^ >actual 2>&1 &&
301+
GIT_PRINT_SHA1_ELLIPSIS=Yes git -c 'core.abbrev=12' checkout HEAD^ >actual 2>&1 &&
302302
check_detached &&
303303
test_i18ncmp 2nd_detach actual &&
304304
305-
GIT_PRINT_SHA1_ELLIPSIS=yes git -c 'core.abbrev=12' checkout HEAD^ >actual 2>&1 &&
305+
GIT_PRINT_SHA1_ELLIPSIS=YES git -c 'core.abbrev=12' checkout HEAD^ >actual 2>&1 &&
306306
check_detached &&
307307
test_i18ncmp 3rd_detach actual &&
308308

0 commit comments

Comments
 (0)