Skip to content

Commit 6501580

Browse files
sorganovgitster
authored andcommitted
revision: change "--diff-merges" option to require parameter
--diff-merges=off is the only accepted form for now, a synonym for --no-diff-merges. This patch is a preparation for adding more values, as well as supporting --diff-merges=<parent>, where <parent> is single parent number to output diff against. Signed-off-by: Sergey Organov <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 5fbb4bc commit 6501580

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

revision.c

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2323,8 +2323,15 @@ static int handle_revision_opt(struct rev_info *revs, int argc, const char **arg
23232323
revs->diff = 1;
23242324
revs->diffopt.flags.recursive = 1;
23252325
revs->diffopt.flags.tree_in_recursive = 1;
2326-
} else if (!strcmp(arg, "-m") || !strcmp(arg, "--diff-merges")) {
2326+
} else if (!strcmp(arg, "-m")) {
23272327
revs->ignore_merges = 0;
2328+
} else if ((argcount = parse_long_opt("diff-merges", argv, &optarg))) {
2329+
if (!strcmp(optarg, "off")) {
2330+
revs->ignore_merges = 1;
2331+
} else {
2332+
die(_("unknown value for --diff-merges: %s"), optarg);
2333+
}
2334+
return argcount;
23282335
} else if (!strcmp(arg, "--no-diff-merges")) {
23292336
revs->ignore_merges = 1;
23302337
} else if (!strcmp(arg, "-c")) {

0 commit comments

Comments
 (0)