Skip to content

Commit 67a612c

Browse files
jrngitster
authored andcommitted
test: remove a porcelain test that hard-codes commit names
The rev-list output in this test depends on the details of test_tick's dummy dates and the choice of hash function. Worse, it depends on the order and nature of commits made in the earlier tests, so adding new tests or rearranging existing ones breaks it. It would be nice to check that "git commit" and commit-tree name objects consistently and that commit objects' text is as documented, but this particular test checks everything at once and hence is not a robust test for that. Remove it. Signed-off-by: Jonathan Nieder <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 7b438f6 commit 67a612c

File tree

1 file changed

+0
-20
lines changed

1 file changed

+0
-20
lines changed

t/t7501-commit.sh

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -144,10 +144,6 @@ test_expect_success PERL \
144144
git diff >diff2 &&
145145
test_cmp diff1 diff2"
146146

147-
test_expect_success \
148-
"showing committed revisions" \
149-
"git rev-list HEAD >current"
150-
151147
cat >editor <<\EOF
152148
#!/bin/sh
153149
sed -e "s/good/bad/g" < "$1" > "$1-"
@@ -168,22 +164,6 @@ test_expect_success \
168164
echo "Another good message." | EDITOR=./editor git commit -a -F - &&
169165
git show -s --pretty=format:"%s" | grep -q good
170166
'
171-
# We could just check the head sha1, but checking each commit makes it
172-
# easier to isolate bugs.
173-
174-
cat >expected <<\EOF
175-
285fcf7ec0d61b14249dfdb4c1e1fe03eaf15ee0
176-
0b8148b9afce917b87d71199b900466dc8ea8b6e
177-
43fb8826314939ce79a856face7953557fdca3d1
178-
eaa04bc3ae0f0b003f7f1d86bf869ec5d73eaf3e
179-
ee1963b250ee0f02a3fe37be0e4a02bb5af6a1ad
180-
b49f306003c627361a0304d151a6b4c8b26af6a1
181-
402702b49136e7587daa9280e91e4bb7cb2179f7
182-
EOF
183-
184-
test_expect_success \
185-
'validate git rev-list output.' \
186-
'test_cmp expected current'
187167

188168
test_expect_success 'partial commit that involves removal (1)' '
189169

0 commit comments

Comments
 (0)