Skip to content

Commit 690eb05

Browse files
ttaylorrgitster
authored andcommitted
builtin/multi-pack-index.c: don't enter bogus cmd_mode
Even before the recent refactoring, 'git multi-pack-index' calls 'trace2_cmd_mode()' before verifying that the sub-command is recognized. Push this call down into the individual sub-commands so that we don't enter a bogus command mode. Signed-off-by: Ævar Arnfjörð Bjarmason <[email protected]> Signed-off-by: Taylor Blau <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 60ca947 commit 690eb05

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

builtin/multi-pack-index.c

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,8 @@ static int cmd_multi_pack_index_write(int argc, const char **argv)
6363
{
6464
struct option *options = common_opts;
6565

66+
trace2_cmd_mode(argv[0]);
67+
6668
argc = parse_options(argc, argv, NULL,
6769
options, builtin_multi_pack_index_write_usage,
6870
PARSE_OPT_KEEP_UNKNOWN);
@@ -77,6 +79,8 @@ static int cmd_multi_pack_index_verify(int argc, const char **argv)
7779
{
7880
struct option *options = common_opts;
7981

82+
trace2_cmd_mode(argv[0]);
83+
8084
argc = parse_options(argc, argv, NULL,
8185
options, builtin_multi_pack_index_verify_usage,
8286
PARSE_OPT_KEEP_UNKNOWN);
@@ -91,6 +95,8 @@ static int cmd_multi_pack_index_expire(int argc, const char **argv)
9195
{
9296
struct option *options = common_opts;
9397

98+
trace2_cmd_mode(argv[0]);
99+
94100
argc = parse_options(argc, argv, NULL,
95101
options, builtin_multi_pack_index_expire_usage,
96102
PARSE_OPT_KEEP_UNKNOWN);
@@ -112,6 +118,8 @@ static int cmd_multi_pack_index_repack(int argc, const char **argv)
112118

113119
options = add_common_options(builtin_multi_pack_index_repack_options);
114120

121+
trace2_cmd_mode(argv[0]);
122+
115123
argc = parse_options(argc, argv, NULL,
116124
options,
117125
builtin_multi_pack_index_repack_usage,
@@ -147,8 +155,6 @@ int cmd_multi_pack_index(int argc, const char **argv,
147155
usage_with_options(builtin_multi_pack_index_usage,
148156
builtin_multi_pack_index_options);
149157

150-
trace2_cmd_mode(argv[0]);
151-
152158
if (!strcmp(argv[0], "repack"))
153159
return cmd_multi_pack_index_repack(argc, argv);
154160
else if (!strcmp(argv[0], "write"))

0 commit comments

Comments
 (0)