Skip to content

Commit 692dfdf

Browse files
committed
transport-helper: read helper response with strbuf_getline()
Our implementation of helpers never use CRLF line endings, and they do not depend on the ability to place a CR as payload at the end of the line, so this is essentially a no-op for in-tree users. However, this allows third-party implementation of helpers to give us their line with CRLF line ending (they cannot expect us to feed CRLF to them, though). Signed-off-by: Junio C Hamano <[email protected]>
1 parent 3f16396 commit 692dfdf

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

transport-helper.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ static int recvline_fh(FILE *helper, struct strbuf *buffer, const char *name)
5454
strbuf_reset(buffer);
5555
if (debug)
5656
fprintf(stderr, "Debug: Remote helper: Waiting...\n");
57-
if (strbuf_getline_lf(buffer, helper) == EOF) {
57+
if (strbuf_getline(buffer, helper) == EOF) {
5858
if (debug)
5959
fprintf(stderr, "Debug: Remote helper quit.\n");
6060
return 1;

0 commit comments

Comments
 (0)