Skip to content

Commit 6badfb3

Browse files
committed
credential-store: avoid assertion
As of 1a9d15d (tempfile: a new module for handling temporary files, 2015-08-10), the temporary files which are used by the lock file machinery adjust the permissions, and to do that, the config is read, which in turn requires the config to be read. This means that the runtime prefix needs to be resolved properly, but we did not set that correctly in credential-store. The symptom of this bug: when running printf '%s\n%s\n%s\n%s\n' \ 'protocol=https' 'host=gitblub.com' \ 'username=hello' 'password=world' | git credential-store store an assertion is thrown: Assertion failed! Program: ...\libexec\git-core\git-credential-store.exe File: exec_cmd.c, Line 23 Expression: argv0_path This application has requested the Runtime to terminate it in an unusual way. Please contact the application's support team for more information. This fixes #766 Signed-off-by: Johannes Schindelin <[email protected]>
1 parent ebcf257 commit 6badfb3

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

credential-store.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
#include "credential.h"
44
#include "string-list.h"
55
#include "parse-options.h"
6+
#include "exec_cmd.h"
67

78
static struct lock_file credential_lock;
89

@@ -160,6 +161,7 @@ int main(int argc, char **argv)
160161

161162
umask(077);
162163

164+
git_extract_argv0_path(argv[0]);
163165
argc = parse_options(argc, (const char **)argv, NULL, options, usage, 0);
164166
if (argc != 1)
165167
usage_with_options(usage, options);

0 commit comments

Comments
 (0)