Skip to content

Commit 6d49de4

Browse files
max630gitster
authored andcommitted
t6023-merge-file.sh: fix and mark as broken invalid tests
Tests "merge without conflict (missing LF at EOF" and "merge result added missing LF" are meaningless - the first one is identical to "merge without conflict" and the second compares results of those identical tests, which are always same. This has been so since their addition in ba1f5f3. Probably "new4.txt" was meant to be used instead of "new2.txt". Unfortunately, the current merge-file breaks with new4 - conflict is reported. They also fail at that revision if fixed. Fix the file reference to "new4.txt" and mark the tests as failing - they look like legitimate expectations, just not satisfied at time being. Signed-off-by: Max Kirillov <[email protected]> Acked-by: Johannes Schindelin <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 7fe6834 commit 6d49de4

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

t/t6023-merge-file.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,10 +77,10 @@ test_expect_success "merge without conflict (--quiet)" \
7777
"git merge-file --quiet test.txt orig.txt new2.txt"
7878

7979
cp new1.txt test2.txt
80-
test_expect_success "merge without conflict (missing LF at EOF)" \
81-
"git merge-file test2.txt orig.txt new2.txt"
80+
test_expect_failure "merge without conflict (missing LF at EOF)" \
81+
"git merge-file test2.txt orig.txt new4.txt"
8282

83-
test_expect_success "merge result added missing LF" \
83+
test_expect_failure "merge result added missing LF" \
8484
"test_cmp test.txt test2.txt"
8585

8686
cp test.txt backup.txt

0 commit comments

Comments
 (0)