Skip to content

Commit 6e556c4

Browse files
avargitster
authored andcommitted
submodule--helper: rename "absorb-git-dirs" to "absorbgitdirs"
Rename the "absorb-git-dirs" subcommand to "absorbgitdirs", which is what the "git submodule" command itself has called it since the subcommand was implemented in f6f8586 (submodule: add absorb-git-dir function, 2016-12-12). Having these two be different will make it more tedious to dispatch to eventually dispatch "git submodule--helper" directly, as we'd need to retain this name mapping. So let's get rid of this needless inconsistency. Signed-off-by: Ævar Arnfjörð Bjarmason <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 0d68ee7 commit 6e556c4

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

builtin/submodule--helper.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2787,7 +2787,7 @@ static int absorb_git_dirs(int argc, const char **argv, const char *prefix)
27872787
};
27882788

27892789
const char *const git_submodule_helper_usage[] = {
2790-
N_("git submodule--helper absorb-git-dirs [<options>] [<path>...]"),
2790+
N_("git submodule--helper absorbgitdirs [<options>] [<path>...]"),
27912791
NULL
27922792
};
27932793

@@ -3389,7 +3389,7 @@ static struct cmd_struct commands[] = {
33893389
{"deinit", module_deinit, 0},
33903390
{"summary", module_summary, SUPPORT_SUPER_PREFIX},
33913391
{"push-check", push_check, 0},
3392-
{"absorb-git-dirs", absorb_git_dirs, SUPPORT_SUPER_PREFIX},
3392+
{"absorbgitdirs", absorb_git_dirs, SUPPORT_SUPER_PREFIX},
33933393
{"is-active", is_active, 0},
33943394
{"check-name", check_name, 0},
33953395
{"config", module_config, 0},

git-submodule.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -552,7 +552,7 @@ cmd_sync()
552552

553553
cmd_absorbgitdirs()
554554
{
555-
git submodule--helper absorb-git-dirs --prefix "$wt_prefix" "$@"
555+
git submodule--helper absorbgitdirs --prefix "$wt_prefix" "$@"
556556
}
557557

558558
# This loop parses the command line arguments to find the

submodule.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2374,7 +2374,7 @@ void absorb_git_dir_into_superproject(const char *path,
23742374
cp.no_stdin = 1;
23752375
strvec_pushl(&cp.args, "--super-prefix", sb.buf,
23762376
"submodule--helper",
2377-
"absorb-git-dirs", NULL);
2377+
"absorbgitdirs", NULL);
23782378
prepare_submodule_repo_env(&cp.env);
23792379
if (run_command(&cp))
23802380
die(_("could not recurse into submodule '%s'"), path);

0 commit comments

Comments
 (0)