Skip to content

Commit 715a51b

Browse files
dschogitster
authored andcommitted
am: counteract gender bias
Since 47f0b6d (Fall back to three-way merge when applying a patch., 2005-10-06), i.e. for almost 11 years already, we used a male form to describe "the other tree". While it was unintended, this gave the erroneous impression as if the Git developers thought of users as male, and were unaware of the important role in software development played by female actors such as Ada Lovelace, Grace Hopper and Margaret Hamilton. In fact, the first professional software developers were all female. Let's change those unfortunate references to the gender neutral "their tree". Doing so also makes the fallback_merge_recursive(), which is an oddball, more in line with the other parts of the system where we contrast what we have vs what we obtain from others by saying "ours" vs "theirs". This inconsistency was also unintended. Signed-off-by: Johannes Schindelin <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 0b65a8d commit 715a51b

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

builtin/am.c

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1579,30 +1579,30 @@ static int build_fake_ancestor(const struct am_state *state, const char *index_f
15791579
}
15801580

15811581
/**
1582-
* Do the three-way merge using fake ancestor, his tree constructed
1582+
* Do the three-way merge using fake ancestor, their tree constructed
15831583
* from the fake ancestor and the postimage of the patch, and our
15841584
* state.
15851585
*/
15861586
static int run_fallback_merge_recursive(const struct am_state *state,
15871587
unsigned char *orig_tree,
15881588
unsigned char *our_tree,
1589-
unsigned char *his_tree)
1589+
unsigned char *their_tree)
15901590
{
15911591
struct child_process cp = CHILD_PROCESS_INIT;
15921592
int status;
15931593

15941594
cp.git_cmd = 1;
15951595

15961596
argv_array_pushf(&cp.env_array, "GITHEAD_%s=%.*s",
1597-
sha1_to_hex(his_tree), linelen(state->msg), state->msg);
1597+
sha1_to_hex(their_tree), linelen(state->msg), state->msg);
15981598
if (state->quiet)
15991599
argv_array_push(&cp.env_array, "GIT_MERGE_VERBOSITY=0");
16001600

16011601
argv_array_push(&cp.args, "merge-recursive");
16021602
argv_array_push(&cp.args, sha1_to_hex(orig_tree));
16031603
argv_array_push(&cp.args, "--");
16041604
argv_array_push(&cp.args, sha1_to_hex(our_tree));
1605-
argv_array_push(&cp.args, sha1_to_hex(his_tree));
1605+
argv_array_push(&cp.args, sha1_to_hex(their_tree));
16061606

16071607
status = run_command(&cp) ? (-1) : 0;
16081608
discard_cache();
@@ -1615,7 +1615,7 @@ static int run_fallback_merge_recursive(const struct am_state *state,
16151615
*/
16161616
static int fall_back_threeway(const struct am_state *state, const char *index_path)
16171617
{
1618-
unsigned char orig_tree[GIT_SHA1_RAWSZ], his_tree[GIT_SHA1_RAWSZ],
1618+
unsigned char orig_tree[GIT_SHA1_RAWSZ], their_tree[GIT_SHA1_RAWSZ],
16191619
our_tree[GIT_SHA1_RAWSZ];
16201620

16211621
if (get_sha1("HEAD", our_tree) < 0)
@@ -1652,7 +1652,7 @@ static int fall_back_threeway(const struct am_state *state, const char *index_pa
16521652
return error(_("Did you hand edit your patch?\n"
16531653
"It does not apply to blobs recorded in its index."));
16541654

1655-
if (write_index_as_tree(his_tree, &the_index, index_path, 0, NULL))
1655+
if (write_index_as_tree(their_tree, &the_index, index_path, 0, NULL))
16561656
return error("could not write tree");
16571657

16581658
say(state, stdout, _("Falling back to patching base and 3-way merge..."));
@@ -1662,13 +1662,13 @@ static int fall_back_threeway(const struct am_state *state, const char *index_pa
16621662

16631663
/*
16641664
* This is not so wrong. Depending on which base we picked, orig_tree
1665-
* may be wildly different from ours, but his_tree has the same set of
1665+
* may be wildly different from ours, but their_tree has the same set of
16661666
* wildly different changes in parts the patch did not touch, so
16671667
* recursive ends up canceling them, saying that we reverted all those
16681668
* changes.
16691669
*/
16701670

1671-
if (run_fallback_merge_recursive(state, orig_tree, our_tree, his_tree)) {
1671+
if (run_fallback_merge_recursive(state, orig_tree, our_tree, their_tree)) {
16721672
rerere(state->allow_rerere_autoupdate);
16731673
return error(_("Failed to merge in the changes."));
16741674
}

0 commit comments

Comments
 (0)