Skip to content

Commit 71f4a93

Browse files
dschogitster
authored andcommitted
t5526: drop the prereq expecting the default branch name main
Initially, we started converting this test script in anticipation for renaming the default branch name to `main`. To that end, we partially converted it to accommodate for that default branch name, marking the now-failing test cases with a prereq that was designed to be fulfilled once the rename was complete. However, the effort to move to the branch name `main` needs quite a bit longer, as it was decided that we need a deprecation phase first. To avoid keeping t5526 in limbo for such a long time, we just made it independent of the actual default branch name used by Git. Therefore, that prereq is no longer necessary, and we can drop it. Signed-off-by: Johannes Schindelin <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent b618a2d commit 71f4a93

File tree

1 file changed

+21
-21
lines changed

1 file changed

+21
-21
lines changed

t/t5526-fetch-submodules.sh

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ test_expect_success setup '
6464
)
6565
'
6666

67-
test_expect_success PREPARE_FOR_MAIN_BRANCH "fetch --recurse-submodules recurses into submodules" '
67+
test_expect_success "fetch --recurse-submodules recurses into submodules" '
6868
add_upstream_commit &&
6969
(
7070
cd downstream &&
@@ -74,7 +74,7 @@ test_expect_success PREPARE_FOR_MAIN_BRANCH "fetch --recurse-submodules recurses
7474
test_i18ncmp expect.err actual.err
7575
'
7676

77-
test_expect_success PREPARE_FOR_MAIN_BRANCH "submodule.recurse option triggers recursive fetch" '
77+
test_expect_success "submodule.recurse option triggers recursive fetch" '
7878
add_upstream_commit &&
7979
(
8080
cd downstream &&
@@ -84,7 +84,7 @@ test_expect_success PREPARE_FOR_MAIN_BRANCH "submodule.recurse option triggers r
8484
test_i18ncmp expect.err actual.err
8585
'
8686

87-
test_expect_success PREPARE_FOR_MAIN_BRANCH "fetch --recurse-submodules -j2 has the same output behaviour" '
87+
test_expect_success "fetch --recurse-submodules -j2 has the same output behaviour" '
8888
add_upstream_commit &&
8989
(
9090
cd downstream &&
@@ -114,7 +114,7 @@ test_expect_success "fetch --no-recurse-submodules only fetches superproject" '
114114
test_must_be_empty actual.err
115115
'
116116

117-
test_expect_success PREPARE_FOR_MAIN_BRANCH "using fetchRecurseSubmodules=true in .gitmodules recurses into submodules" '
117+
test_expect_success "using fetchRecurseSubmodules=true in .gitmodules recurses into submodules" '
118118
(
119119
cd downstream &&
120120
git config -f .gitmodules submodule.submodule.fetchRecurseSubmodules true &&
@@ -144,7 +144,7 @@ test_expect_success "using fetchRecurseSubmodules=false in .git/config overrides
144144
test_must_be_empty actual.err
145145
'
146146

147-
test_expect_success PREPARE_FOR_MAIN_BRANCH "--recurse-submodules overrides fetchRecurseSubmodules setting from .git/config" '
147+
test_expect_success "--recurse-submodules overrides fetchRecurseSubmodules setting from .git/config" '
148148
(
149149
cd downstream &&
150150
git fetch --recurse-submodules >../actual.out 2>../actual.err &&
@@ -173,7 +173,7 @@ test_expect_success "--quiet propagates to parallel submodules" '
173173
test_must_be_empty actual.err
174174
'
175175

176-
test_expect_success PREPARE_FOR_MAIN_BRANCH "--dry-run propagates to submodules" '
176+
test_expect_success "--dry-run propagates to submodules" '
177177
add_upstream_commit &&
178178
(
179179
cd downstream &&
@@ -183,7 +183,7 @@ test_expect_success PREPARE_FOR_MAIN_BRANCH "--dry-run propagates to submodules"
183183
test_i18ncmp expect.err actual.err
184184
'
185185

186-
test_expect_success PREPARE_FOR_MAIN_BRANCH "Without --dry-run propagates to submodules" '
186+
test_expect_success "Without --dry-run propagates to submodules" '
187187
(
188188
cd downstream &&
189189
git fetch --recurse-submodules >../actual.out 2>../actual.err
@@ -192,7 +192,7 @@ test_expect_success PREPARE_FOR_MAIN_BRANCH "Without --dry-run propagates to sub
192192
test_i18ncmp expect.err actual.err
193193
'
194194

195-
test_expect_success PREPARE_FOR_MAIN_BRANCH "recurseSubmodules=true propagates into submodules" '
195+
test_expect_success "recurseSubmodules=true propagates into submodules" '
196196
add_upstream_commit &&
197197
(
198198
cd downstream &&
@@ -203,7 +203,7 @@ test_expect_success PREPARE_FOR_MAIN_BRANCH "recurseSubmodules=true propagates i
203203
test_i18ncmp expect.err actual.err
204204
'
205205

206-
test_expect_success PREPARE_FOR_MAIN_BRANCH "--recurse-submodules overrides config in submodule" '
206+
test_expect_success "--recurse-submodules overrides config in submodule" '
207207
add_upstream_commit &&
208208
(
209209
cd downstream &&
@@ -228,7 +228,7 @@ test_expect_success "--no-recurse-submodules overrides config setting" '
228228
test_must_be_empty actual.err
229229
'
230230

231-
test_expect_success PREPARE_FOR_MAIN_BRANCH "Recursion doesn't happen when no new commits are fetched in the superproject" '
231+
test_expect_success "Recursion doesn't happen when no new commits are fetched in the superproject" '
232232
(
233233
cd downstream &&
234234
(
@@ -242,7 +242,7 @@ test_expect_success PREPARE_FOR_MAIN_BRANCH "Recursion doesn't happen when no ne
242242
test_must_be_empty actual.err
243243
'
244244

245-
test_expect_success PREPARE_FOR_MAIN_BRANCH "Recursion stops when no new submodule commits are fetched" '
245+
test_expect_success "Recursion stops when no new submodule commits are fetched" '
246246
head1=$(git rev-parse --short HEAD) &&
247247
git add submodule &&
248248
git commit -m "new submodule" &&
@@ -258,7 +258,7 @@ test_expect_success PREPARE_FOR_MAIN_BRANCH "Recursion stops when no new submodu
258258
test_must_be_empty actual.out
259259
'
260260

261-
test_expect_success PREPARE_FOR_MAIN_BRANCH "Recursion doesn't happen when new superproject commits don't change any submodules" '
261+
test_expect_success "Recursion doesn't happen when new superproject commits don't change any submodules" '
262262
add_upstream_commit &&
263263
head1=$(git rev-parse --short HEAD) &&
264264
echo a > file &&
@@ -275,7 +275,7 @@ test_expect_success PREPARE_FOR_MAIN_BRANCH "Recursion doesn't happen when new s
275275
test_i18ncmp expect.err.file actual.err
276276
'
277277

278-
test_expect_success PREPARE_FOR_MAIN_BRANCH "Recursion picks up config in submodule" '
278+
test_expect_success "Recursion picks up config in submodule" '
279279
(
280280
cd downstream &&
281281
git fetch --recurse-submodules &&
@@ -304,7 +304,7 @@ test_expect_success PREPARE_FOR_MAIN_BRANCH "Recursion picks up config in submod
304304
test_must_be_empty actual.out
305305
'
306306

307-
test_expect_success PREPARE_FOR_MAIN_BRANCH "Recursion picks up all submodules when necessary" '
307+
test_expect_success "Recursion picks up all submodules when necessary" '
308308
add_upstream_commit &&
309309
(
310310
cd submodule &&
@@ -337,7 +337,7 @@ test_expect_success PREPARE_FOR_MAIN_BRANCH "Recursion picks up all submodules w
337337
test_must_be_empty actual.out
338338
'
339339

340-
test_expect_success PREPARE_FOR_MAIN_BRANCH "'--recurse-submodules=on-demand' doesn't recurse when no new commits are fetched in the superproject (and ignores config)" '
340+
test_expect_success "'--recurse-submodules=on-demand' doesn't recurse when no new commits are fetched in the superproject (and ignores config)" '
341341
add_upstream_commit &&
342342
(
343343
cd submodule &&
@@ -364,7 +364,7 @@ test_expect_success PREPARE_FOR_MAIN_BRANCH "'--recurse-submodules=on-demand' do
364364
test_must_be_empty actual.err
365365
'
366366

367-
test_expect_success PREPARE_FOR_MAIN_BRANCH "'--recurse-submodules=on-demand' recurses as deep as necessary (and ignores config)" '
367+
test_expect_success "'--recurse-submodules=on-demand' recurses as deep as necessary (and ignores config)" '
368368
head1=$(git rev-parse --short HEAD) &&
369369
git add submodule &&
370370
git commit -m "new submodule" &&
@@ -392,7 +392,7 @@ test_expect_success PREPARE_FOR_MAIN_BRANCH "'--recurse-submodules=on-demand' re
392392
test_i18ncmp expect.err actual.err
393393
'
394394

395-
test_expect_success PREPARE_FOR_MAIN_BRANCH "'--recurse-submodules=on-demand' stops when no new submodule commits are found in the superproject (and ignores config)" '
395+
test_expect_success "'--recurse-submodules=on-demand' stops when no new submodule commits are found in the superproject (and ignores config)" '
396396
add_upstream_commit &&
397397
head1=$(git rev-parse --short HEAD) &&
398398
echo a >> file &&
@@ -409,7 +409,7 @@ test_expect_success PREPARE_FOR_MAIN_BRANCH "'--recurse-submodules=on-demand' st
409409
test_i18ncmp expect.err.file actual.err
410410
'
411411

412-
test_expect_success PREPARE_FOR_MAIN_BRANCH "'fetch.recurseSubmodules=on-demand' overrides global config" '
412+
test_expect_success "'fetch.recurseSubmodules=on-demand' overrides global config" '
413413
(
414414
cd downstream &&
415415
git fetch --recurse-submodules
@@ -437,7 +437,7 @@ test_expect_success PREPARE_FOR_MAIN_BRANCH "'fetch.recurseSubmodules=on-demand'
437437
test_i18ncmp expect.err.2 actual.err
438438
'
439439

440-
test_expect_success PREPARE_FOR_MAIN_BRANCH "'submodule.<sub>.fetchRecurseSubmodules=on-demand' overrides fetch.recurseSubmodules" '
440+
test_expect_success "'submodule.<sub>.fetchRecurseSubmodules=on-demand' overrides fetch.recurseSubmodules" '
441441
(
442442
cd downstream &&
443443
git fetch --recurse-submodules
@@ -465,7 +465,7 @@ test_expect_success PREPARE_FOR_MAIN_BRANCH "'submodule.<sub>.fetchRecurseSubmod
465465
test_i18ncmp expect.err.2 actual.err
466466
'
467467

468-
test_expect_success PREPARE_FOR_MAIN_BRANCH "don't fetch submodule when newly recorded commits are already present" '
468+
test_expect_success "don't fetch submodule when newly recorded commits are already present" '
469469
(
470470
cd submodule &&
471471
git checkout -q HEAD^^
@@ -488,7 +488,7 @@ test_expect_success PREPARE_FOR_MAIN_BRANCH "don't fetch submodule when newly re
488488
)
489489
'
490490

491-
test_expect_success PREPARE_FOR_MAIN_BRANCH "'fetch.recurseSubmodules=on-demand' works also without .gitmodules entry" '
491+
test_expect_success "'fetch.recurseSubmodules=on-demand' works also without .gitmodules entry" '
492492
(
493493
cd downstream &&
494494
git fetch --recurse-submodules

0 commit comments

Comments
 (0)