submodule: check argc count for git submodule--helper clone

Extra unused arguments to git submodule--helper clone subcommand were
being silently ignored. Add a check to the argc count after options
handling to ensure that no extra arguments were left on the argv array.

Signed-off-by: Jacob Keller <[email protected]>
Reviewed-by: Stefan Beller <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>

Author: jacob-keller

builtin/submodule--helper.c

@@ -191,6 +191,10 @@ static int module_clone(int argc, const char **argv, const char *prefix)
 	if (!path || !*path)
 		die(_("submodule--helper: unspecified or empty --path"));
 
+	if (argc)
+		usage_with_options(git_submodule_helper_usage,
+				   module_clone_options);
+
 	strbuf_addf(&sb, "%s/modules/%s", get_git_dir(), name);
 	sm_gitdir = xstrdup(absolute_path(sb.buf));
 	strbuf_reset(&sb);