Skip to content

Commit 73eb180

Browse files
libbacktrace: use __attribute__((__fallthrough__))
Use an attribute rather than a comment when falling through a switch case. * internal.h (ATTRIBUTE_FALLTHROUGH): Define. * elf.c (elf_zlib_inflate): Use ATTRIBUTE_FALLTHROUGH.
1 parent 5009c11 commit 73eb180

File tree

2 files changed

+16
-8
lines changed

2 files changed

+16
-8
lines changed

elf.c

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2081,10 +2081,10 @@ elf_zlib_inflate (const unsigned char *pin, size_t sin, uint16_t *zdebug_table,
20812081
{
20822082
case 6:
20832083
*plen++ = prev;
2084-
/* fallthrough */
2084+
ATTRIBUTE_FALLTHROUGH;
20852085
case 5:
20862086
*plen++ = prev;
2087-
/* fallthrough */
2087+
ATTRIBUTE_FALLTHROUGH;
20882088
case 4:
20892089
*plen++ = prev;
20902090
}
@@ -2115,22 +2115,22 @@ elf_zlib_inflate (const unsigned char *pin, size_t sin, uint16_t *zdebug_table,
21152115
{
21162116
case 10:
21172117
*plen++ = 0;
2118-
/* fallthrough */
2118+
ATTRIBUTE_FALLTHROUGH;
21192119
case 9:
21202120
*plen++ = 0;
2121-
/* fallthrough */
2121+
ATTRIBUTE_FALLTHROUGH;
21222122
case 8:
21232123
*plen++ = 0;
2124-
/* fallthrough */
2124+
ATTRIBUTE_FALLTHROUGH;
21252125
case 7:
21262126
*plen++ = 0;
2127-
/* fallthrough */
2127+
ATTRIBUTE_FALLTHROUGH;
21282128
case 6:
21292129
*plen++ = 0;
2130-
/* fallthrough */
2130+
ATTRIBUTE_FALLTHROUGH;
21312131
case 5:
21322132
*plen++ = 0;
2133-
/* fallthrough */
2133+
ATTRIBUTE_FALLTHROUGH;
21342134
case 4:
21352135
*plen++ = 0;
21362136
}

internal.h

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,14 @@ POSSIBILITY OF SUCH DAMAGE. */
5656
# endif
5757
#endif
5858

59+
#ifndef ATTRIBUTE_FALLTHROUGH
60+
# if (GCC_VERSION >= 7000)
61+
# define ATTRIBUTE_FALLTHROUGH __attribute__ ((__fallthrough__))
62+
# else
63+
# define ATTRIBUTE_FALLTHROUGH
64+
# endif
65+
#endif
66+
5967
#ifndef HAVE_SYNC_FUNCTIONS
6068

6169
/* Define out the sync functions. These should never be called if

0 commit comments

Comments
 (0)