Skip to content

Commit 795fcb0

Browse files
devzero2000gitster
authored andcommitted
t/t9814-git-p4-rename.sh: avoid "test <cond> -a/-o <cond>"
The construct is error-prone; "test" being built-in in most modern shells, the reason to avoid "test <cond> && test <cond>" spawning one extra process by using a single "test <cond> -a <cond>" no longer exists. Signed-off-by: Elia Pinto <[email protected]> Reviewed-by: Matthieu Moy <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 754b574 commit 795fcb0

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

t/t9814-git-p4-rename.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ test_expect_success 'detect copies' '
177177
level=$(git diff-tree -r -C --find-copies-harder HEAD | sed 1d | cut -f1 | cut -d" " -f5 | sed "s/C0*//") &&
178178
test -n "$level" && test "$level" -gt 0 && test "$level" -lt 98 &&
179179
src=$(git diff-tree -r -C --find-copies-harder HEAD | sed 1d | cut -f2) &&
180-
test "$src" = file10 -o "$src" = file11 &&
180+
test "$src" = file10 || test "$src" = file11 &&
181181
git config git-p4.detectCopies $(($level + 2)) &&
182182
git p4 submit &&
183183
p4 filelog //depot/file12 &&
@@ -191,7 +191,7 @@ test_expect_success 'detect copies' '
191191
level=$(git diff-tree -r -C --find-copies-harder HEAD | sed 1d | cut -f1 | cut -d" " -f5 | sed "s/C0*//") &&
192192
test -n "$level" && test "$level" -gt 2 && test "$level" -lt 100 &&
193193
src=$(git diff-tree -r -C --find-copies-harder HEAD | sed 1d | cut -f2) &&
194-
test "$src" = file10 -o "$src" = file11 -o "$src" = file12 &&
194+
test "$src" = file10 || test "$src" = file11 || test "$src" = file12 &&
195195
git config git-p4.detectCopies $(($level - 2)) &&
196196
git p4 submit &&
197197
p4 filelog //depot/file13 &&

0 commit comments

Comments
 (0)