Skip to content

Commit 796c248

Browse files
peffgitster
authored andcommitted
git-svn tests: rewrite brittle tests to use "--[no-]merges".
Rewrite a brittle tests which used "rev-list" without "--[no-]merges" to figure out if a set of commits turned into merge commits or not. Signed-off-by: Jeff King <[email protected]> [ÆAB: wrote commit message] Signed-off-by: Ævar Arnfjörð Bjarmason <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent f918a89 commit 796c248

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

t/t9151-svn-mergeinfo.sh

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,21 +17,17 @@ test_expect_success 'load svn dump' "
1717
"
1818

1919
test_expect_success 'all svn merges became git merge commits' '
20-
git rev-list --parents --all --grep=Merge |
21-
grep -v " .* " | cut -f1 -d" " >unmarked &&
20+
git rev-list --all --no-merges --grep=Merge >unmarked &&
2221
test_must_be_empty unmarked
2322
'
2423

25-
2624
test_expect_success 'cherry picks did not become git merge commits' '
27-
git rev-list --parents --all --grep=Cherry |
28-
grep " .* " | cut -f1 -d" " >bad-cherries &&
25+
git rev-list --all --merges --grep=Cherry >bad-cherries &&
2926
test_must_be_empty bad-cherries
3027
'
3128

3229
test_expect_success 'svn non-merge merge commits did not become git merge commits' '
33-
git rev-list --parents --all --grep=non-merge |
34-
grep " .* " | cut -f1 -d" " >bad-non-merges &&
30+
git rev-list --all --merges --grep=non-merge >bad-non-merges &&
3531
test_must_be_empty bad-non-merges
3632
'
3733

0 commit comments

Comments
 (0)