Skip to content

Commit 7a49c25

Browse files
jnarebgitster
authored andcommitted
gitweb: git_get_project_config requires only $git_dir, not also $project
Fix overeager early return in git_get_project_config, introduced in 9be3614 (gitweb: Fix project-specific feature override behavior, 2010-03-01). When git_get_project_config is called from projects list page via git_get_project_owner($path) etc., it is called with $git_dir defined (in git_get_project_owner($path) etc.), but $project variable is not defined. git_get_project_config doesn't use $project variable anyway. Reported-by: Tobias Heinlein <[email protected]> Signed-off-by: Jakub Narebski <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent e476286 commit 7a49c25

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

gitweb/gitweb.perl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2209,8 +2209,7 @@ sub config_to_multi {
22092209
sub git_get_project_config {
22102210
my ($key, $type) = @_;
22112211

2212-
# do we have project
2213-
return unless (defined $project && defined $git_dir);
2212+
return unless defined $git_dir;
22142213

22152214
# key sanity check
22162215
return unless ($key);

0 commit comments

Comments
 (0)