Skip to content

Commit 7acf438

Browse files
René Scharfegitster
authored andcommitted
git: Wrong parsing of ssh urls with IPv6 literals ignores port
If we encounter an address part shaped like "[HOST]:PORT", we skip the opening bracket and replace the closing one with a NUL. The variable host then points to HOST and we've cut off the PORT part. Thus, when we go looking for it using host a bit later, we can't find it. Start at end instead, which either points to the colon, if present, or is equal to host. Signed-off-by: Rene Scharfe <[email protected]> Reviewed-by: Jonathan Nieder <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 121f71f commit 7acf438

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

connect.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -536,7 +536,7 @@ struct child_process *git_connect(int fd[2], const char *url_orig,
536536
* Add support for ssh port: ssh://host.xy:<port>/...
537537
*/
538538
if (protocol == PROTO_SSH && host != url)
539-
port = get_port(host);
539+
port = get_port(end);
540540

541541
if (protocol == PROTO_GIT) {
542542
/* These underlying connection commands die() if they

0 commit comments

Comments
 (0)