Skip to content

Commit 7b20af6

Browse files
committed
am/apply: warn if we end up reading patches from terminal
In an interactive session, "git am" without arguments, or even worse, "git am --whitespace file", waits silently for the user to feed the patches from the standard input (presumably by typing or copy-pasting). Give a feedback message to the user when this happens, as it is unlikely that the user meant to do so. Signed-off-by: Junio C Hamano <[email protected]>
1 parent 4c53a8c commit 7b20af6

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

builtin/mailsplit.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -223,6 +223,9 @@ static int split_mbox(const char *file, const char *dir, int allow_bare,
223223
FILE *f = !strcmp(file, "-") ? stdin : fopen(file, "r");
224224
int file_done = 0;
225225

226+
if (isatty(fileno(f)))
227+
warning(_("reading patches from stdin/tty..."));
228+
226229
if (!f) {
227230
error_errno("cannot open mbox %s", file);
228231
goto out;

0 commit comments

Comments
 (0)