Skip to content

Commit 7b55441

Browse files
committed
Merge branch 'ab/perl-do-not-abuse-map'
Perl critique. * ab/perl-do-not-abuse-map: git-send-email: replace "map" in void context with "for"
2 parents 0623669 + b362acf commit 7b55441

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

git-send-email.perl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -217,12 +217,12 @@ sub do_edit {
217217
$editor = Git::command_oneline('var', 'GIT_EDITOR');
218218
}
219219
if (defined($multiedit) && !$multiedit) {
220-
map {
220+
for (@_) {
221221
system('sh', '-c', $editor.' "$@"', $editor, $_);
222222
if (($? & 127) || ($? >> 8)) {
223223
die(__("the editor exited uncleanly, aborting everything"));
224224
}
225-
} @_;
225+
}
226226
} else {
227227
system('sh', '-c', $editor.' "$@"', $editor, @_);
228228
if (($? & 127) || ($? >> 8)) {

0 commit comments

Comments
 (0)