Skip to content

Commit 7bc734e

Browse files
sunshinecogitster
authored andcommitted
t6302: also test annotated in addition to signed tags
It is conceivable, if not highly plausible, that a change to the git-for-each-ref code that does the filtering and formatting can become buggy because a payload with GPG signature looks somewhat different from what is in an annotated but not signed tag. Thus, let's test unsigned tags, as well. Signed-off-by: Eric Sunshine <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent ef93c7d commit 7bc734e

File tree

1 file changed

+25
-0
lines changed

1 file changed

+25
-0
lines changed

t/t6302-for-each-ref-filter.sh

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@ test_expect_success 'setup some history and refs' '
1717
test_commit three &&
1818
git checkout -b side &&
1919
test_commit four &&
20+
git tag -m "An annotated tag" annotated-tag &&
21+
git tag -m "Annonated doubly" doubly-annotated-tag annotated-tag &&
2022
git tag -s -m "A signed tag" signed-tag &&
2123
git tag -s -m "Signed doubly" doubly-signed-tag signed-tag &&
2224
git checkout master &&
@@ -36,6 +38,7 @@ test_expect_success 'filtering with --points-at' '
3638
test_expect_success 'check signed tags with --points-at' '
3739
sed -e "s/Z$//" >expect <<-\EOF &&
3840
refs/heads/side Z
41+
refs/tags/annotated-tag four
3942
refs/tags/four Z
4043
refs/tags/signed-tag four
4144
EOF
@@ -58,6 +61,8 @@ test_expect_success 'filtering with --merged' '
5861
test_expect_success 'filtering with --no-merged' '
5962
cat >expect <<-\EOF &&
6063
refs/heads/side
64+
refs/tags/annotated-tag
65+
refs/tags/doubly-annotated-tag
6166
refs/tags/doubly-signed-tag
6267
refs/tags/four
6368
refs/tags/signed-tag
@@ -71,6 +76,8 @@ test_expect_success 'filtering with --contains' '
7176
refs/heads/master
7277
refs/heads/side
7378
refs/odd/spot
79+
refs/tags/annotated-tag
80+
refs/tags/doubly-annotated-tag
7481
refs/tags/doubly-signed-tag
7582
refs/tags/four
7683
refs/tags/signed-tag
@@ -90,6 +97,8 @@ test_expect_success 'left alignment is default' '
9097
refname is refs/heads/master |refs/heads/master
9198
refname is refs/heads/side |refs/heads/side
9299
refname is refs/odd/spot |refs/odd/spot
100+
refname is refs/tags/annotated-tag|refs/tags/annotated-tag
101+
refname is refs/tags/doubly-annotated-tag|refs/tags/doubly-annotated-tag
93102
refname is refs/tags/doubly-signed-tag|refs/tags/doubly-signed-tag
94103
refname is refs/tags/four |refs/tags/four
95104
refname is refs/tags/one |refs/tags/one
@@ -106,6 +115,8 @@ test_expect_success 'middle alignment' '
106115
| refname is refs/heads/master |refs/heads/master
107116
| refname is refs/heads/side |refs/heads/side
108117
| refname is refs/odd/spot |refs/odd/spot
118+
|refname is refs/tags/annotated-tag|refs/tags/annotated-tag
119+
|refname is refs/tags/doubly-annotated-tag|refs/tags/doubly-annotated-tag
109120
|refname is refs/tags/doubly-signed-tag|refs/tags/doubly-signed-tag
110121
| refname is refs/tags/four |refs/tags/four
111122
| refname is refs/tags/one |refs/tags/one
@@ -122,6 +133,8 @@ test_expect_success 'right alignment' '
122133
| refname is refs/heads/master|refs/heads/master
123134
| refname is refs/heads/side|refs/heads/side
124135
| refname is refs/odd/spot|refs/odd/spot
136+
|refname is refs/tags/annotated-tag|refs/tags/annotated-tag
137+
|refname is refs/tags/doubly-annotated-tag|refs/tags/doubly-annotated-tag
125138
|refname is refs/tags/doubly-signed-tag|refs/tags/doubly-signed-tag
126139
| refname is refs/tags/four|refs/tags/four
127140
| refname is refs/tags/one|refs/tags/one
@@ -137,6 +150,8 @@ cat >expect <<-\EOF
137150
| refname is refs/heads/master |refs/heads/master
138151
| refname is refs/heads/side |refs/heads/side
139152
| refname is refs/odd/spot |refs/odd/spot
153+
| refname is refs/tags/annotated-tag |refs/tags/annotated-tag
154+
|refname is refs/tags/doubly-annotated-tag |refs/tags/doubly-annotated-tag
140155
| refname is refs/tags/doubly-signed-tag |refs/tags/doubly-signed-tag
141156
| refname is refs/tags/four |refs/tags/four
142157
| refname is refs/tags/one |refs/tags/one
@@ -182,6 +197,8 @@ test_expect_success 'alignment with format quote' "
182197
|' '\''master| A U Thor'\'' '|
183198
|' '\''side| A U Thor'\'' '|
184199
|' '\''odd/spot| A U Thor'\'' '|
200+
|' '\''annotated-tag| '\'' '|
201+
|' '\''doubly-annotated-tag| '\'' '|
185202
|' '\''doubly-signed-tag| '\'' '|
186203
|' '\''four| A U Thor'\'' '|
187204
|' '\''one| A U Thor'\'' '|
@@ -198,6 +215,8 @@ test_expect_success 'nested alignment with quote formatting' "
198215
|' master '|
199216
|' side '|
200217
|' odd/spot '|
218+
|' annotated-tag '|
219+
|'doubly-annotated-tag '|
201220
|'doubly-signed-tag '|
202221
|' four '|
203222
|' one '|
@@ -214,6 +233,8 @@ test_expect_success 'check `%(contents:lines=1)`' '
214233
master |three
215234
side |four
216235
odd/spot |three
236+
annotated-tag |An annotated tag
237+
doubly-annotated-tag |Annonated doubly
217238
doubly-signed-tag |Signed doubly
218239
four |four
219240
one |one
@@ -230,6 +251,8 @@ test_expect_success 'check `%(contents:lines=0)`' '
230251
master |
231252
side |
232253
odd/spot |
254+
annotated-tag |
255+
doubly-annotated-tag |
233256
doubly-signed-tag |
234257
four |
235258
one |
@@ -246,6 +269,8 @@ test_expect_success 'check `%(contents:lines=99999)`' '
246269
master |three
247270
side |four
248271
odd/spot |three
272+
annotated-tag |An annotated tag
273+
doubly-annotated-tag |Annonated doubly
249274
doubly-signed-tag |Signed doubly
250275
four |four
251276
one |one

0 commit comments

Comments
 (0)