Skip to content

Commit 7bd9631

Browse files
peffgitster
authored andcommitted
read-cache: drop unused parameter from threaded load
The load_cache_entries_threaded() function takes a src_offset parameter that it doesn't use. This has been there since its inception in 77ff112 (read-cache: load cache entries on worker threads, 2018-10-10). Digging on the mailing list, that parameter was part of an earlier iteration of the series[1], but became unnecessary when the code switched to using the IEOT extension. [1] https://public-inbox.org/git/[email protected]/ Signed-off-by: Jeff King <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 3c1dce8 commit 7bd9631

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

read-cache.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2037,7 +2037,7 @@ static void *load_cache_entries_thread(void *_data)
20372037
}
20382038

20392039
static unsigned long load_cache_entries_threaded(struct index_state *istate, const char *mmap, size_t mmap_size,
2040-
unsigned long src_offset, int nr_threads, struct index_entry_offset_table *ieot)
2040+
int nr_threads, struct index_entry_offset_table *ieot)
20412041
{
20422042
int i, offset, ieot_blocks, ieot_start, err;
20432043
struct load_cache_entries_thread_data *data;
@@ -2198,7 +2198,7 @@ int do_read_index(struct index_state *istate, const char *path, int must_exist)
21982198
ieot = read_ieot_extension(mmap, mmap_size, extension_offset);
21992199

22002200
if (ieot) {
2201-
src_offset += load_cache_entries_threaded(istate, mmap, mmap_size, src_offset, nr_threads, ieot);
2201+
src_offset += load_cache_entries_threaded(istate, mmap, mmap_size, nr_threads, ieot);
22022202
free(ieot);
22032203
} else {
22042204
src_offset += load_all_cache_entries(istate, mmap, mmap_size, src_offset);

0 commit comments

Comments
 (0)