Fix global repository field not being cleared (#4083)

dscho · mjcheetham · commit 7be154bf2cd0 · 2023-05-19T12:13:32.000-07:00
It is checked for w.r.t. global repository struct down in the callstack
in compatibility layer for MinGW before being assigned in the function
that `free()`'d it.
diff --git a/repository.c b/repository.c
@@ -51,7 +51,7 @@ static void repo_set_commondir(struct repository *repo,
 {
 	struct strbuf sb = STRBUF_INIT;
 
-	free(repo->commondir);
+	FREE_AND_NULL(repo->commondir);
 
 	if (commondir) {
 		repo->different_commondir = 1;

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ static void repo_set_commondir(struct repository *repo,`
`51`	`51`	`{`
`52`	`52`	`struct strbuf sb = STRBUF_INIT;`
`53`	`53`
`54`		`- free(repo->commondir);`
	`54`	`+ FREE_AND_NULL(repo->commondir);`
`55`	`55`
`56`	`56`	`if (commondir) {`
`57`	`57`	`repo->different_commondir = 1;`