Skip to content

Commit 7c0c51b

Browse files
devzero2000gitster
authored andcommitted
t4038-diff-combined.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pinto <[email protected]> Reviewed-by: Matthieu Moy <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 20cb28b commit 7c0c51b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

t/t4038-diff-combined.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ test_expect_success 'setup for --cc --raw' '
9494
blob=$(echo file | git hash-object --stdin -w) &&
9595
base_tree=$(echo "100644 blob $blob file" | git mktree) &&
9696
trees= &&
97-
for i in `test_seq 1 40`
97+
for i in $(test_seq 1 40)
9898
do
9999
blob=$(echo file$i | git hash-object --stdin -w) &&
100100
trees="$trees$(echo "100644 blob $blob file" | git mktree)$LF"

0 commit comments

Comments
 (0)