Skip to content

Commit 7ef4d6b

Browse files
peffgitster
authored andcommitted
t/Makefile: pass test opts to valgrind target properly
The valgrind target just reinvokes make with GIT_TEST_OPTS set to "--valgrind". However, it does this using an environment variable, which means GIT_TEST_OPTS in your config.mak would override it, and "make valgrind" would simply run the test suite without valgrind on. Instead, we should pass GIT_TEST_OPTS on the command-line, overriding what's in config.mak, and take care to append to whatever the user has there already. Signed-off-by: Jeff King <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 179aae5 commit 7ef4d6b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

t/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ gitweb-test:
7171
$(MAKE) $(TGITWEB)
7272

7373
valgrind:
74-
GIT_TEST_OPTS=--valgrind $(MAKE)
74+
$(MAKE) GIT_TEST_OPTS="$(GIT_TEST_OPTS) --valgrind"
7575

7676
# Smoke testing targets
7777
-include ../GIT-VERSION-FILE

0 commit comments

Comments
 (0)