Skip to content

Commit 7f53583

Browse files
carenasgitster
authored andcommitted
credential: update description for credential_from_url_gently
c44088e (credential: treat URL without scheme as invalid, 2020-04-18) changes the implementation for this function to return -1 if protocol is missing. Update blurb to match implementation. Reviewed-by: Jeff King <[email protected]> Signed-off-by: Carlo Marcelo Arenas Belón <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent af6b65d commit 7f53583

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

credential.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -177,8 +177,8 @@ void credential_write(const struct credential *, FILE *);
177177
* Parse a url into a credential struct, replacing any existing contents.
178178
*
179179
* If the url can't be parsed (e.g., a missing "proto://" component), the
180-
* resulting credential will be empty but we'll still return success from the
181-
* "gently" form.
180+
* resulting credential will be empty and the function will return an
181+
* error (even in the "gently" form).
182182
*
183183
* If we encounter a component which cannot be represented as a credential
184184
* value (e.g., because it contains a newline), the "gently" form will return

0 commit comments

Comments
 (0)