completion: bash: improve function detection

felipec · gitster · commit 810df0ea8ed0 · 2021-01-04T15:25:56.000-08:00
1. We should quote the argument
 2. We don't need two redirections
 3. A safeguard for arguments (-a) would be good

Suggested-by: René Scharfe &lt;l.s.r@web.de&gt;
Signed-off-by: Felipe Contreras &lt;felipe.contreras@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
@@ -3359,7 +3359,7 @@ __git_support_parseopt_helper () {
 }
 
 __git_have_func () {
-	declare -f $1 >/dev/null 2>/dev/null
+	declare -f -- "$1" >/dev/null 2>&1
 }
 
 __git_complete_command () {

Original file line number	Diff line number	Diff line change
`@@ -3359,7 +3359,7 @@ __git_support_parseopt_helper () {`
`3359`	`3359`	`}`
`3360`	`3360`
`3361`	`3361`	`__git_have_func () {`
`3362`		`- declare -f $1 >/dev/null 2>/dev/null`
	`3362`	`+ declare -f -- "$1" >/dev/null 2>&1`
`3363`	`3363`	`}`
`3364`	`3364`
`3365`	`3365`	`__git_complete_command () {`