sha256/gcrypt: die on gcry_md_open failures

Eric Wong · gitster · commit 823839bda1a7 · 2023-07-31T08:57:24.000-07:00
`gcry_md_open' allocates memory and must (like all allocation
functions) be checked for failure.

Signed-off-by: Eric Wong &lt;e@80x24.org&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/sha256/gcrypt.h b/sha256/gcrypt.h
@@ -9,7 +9,9 @@ typedef gcry_md_hd_t gcrypt_SHA256_CTX;
 
 static inline void gcrypt_SHA256_Init(gcrypt_SHA256_CTX *ctx)
 {
-	gcry_md_open(ctx, GCRY_MD_SHA256, 0);
+	gcry_error_t err = gcry_md_open(ctx, GCRY_MD_SHA256, 0);
+	if (err)
+		die("gcry_md_open: %s", gcry_strerror(err));
 }
 
 static inline void gcrypt_SHA256_Update(gcrypt_SHA256_CTX *ctx, const void *data, size_t len)

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,9 @@ typedef gcry_md_hd_t gcrypt_SHA256_CTX;`
`9`	`9`
`10`	`10`	`static inline void gcrypt_SHA256_Init(gcrypt_SHA256_CTX *ctx)`
`11`	`11`	`{`
`12`		`- gcry_md_open(ctx, GCRY_MD_SHA256, 0);`
	`12`	`+ gcry_error_t err = gcry_md_open(ctx, GCRY_MD_SHA256, 0);`
	`13`	`+ if (err)`
	`14`	`+ die("gcry_md_open: %s", gcry_strerror(err));`
`13`	`15`	`}`
`14`	`16`
`15`	`17`	`static inline void gcrypt_SHA256_Update(gcrypt_SHA256_CTX ctx, const void data, size_t len)`