Skip to content

Commit 829a1c6

Browse files
peffgitster
authored andcommitted
send-email: multiedit is a boolean config option
The sendemail.multiedit variable is meant to be a boolean. However, it is not marked as such in the code, which means we store its value literally. Thus in the do_edit function, perl ends up coercing it to a boolean value according to perl rules, not git rules. This works for "0", but "false", "no", or "off" will erroneously be interpreted as true. Signed-off-by: Jeff King <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 5f4d133 commit 829a1c6

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

git-send-email.perl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,7 @@ sub do_edit {
210210
"signedoffbycc" => [\$signed_off_by_cc, undef],
211211
"signedoffcc" => [\$signed_off_by_cc, undef], # Deprecated
212212
"validate" => [\$validate, 1],
213+
"multiedit" => [\$multiedit, undef]
213214
);
214215

215216
my %config_settings = (
@@ -227,7 +228,6 @@ sub do_edit {
227228
"bcc" => \@bcclist,
228229
"suppresscc" => \@suppress_cc,
229230
"envelopesender" => \$envelope_sender,
230-
"multiedit" => \$multiedit,
231231
"confirm" => \$confirm,
232232
"from" => \$sender,
233233
"assume8bitencoding" => \$auto_8bit_encoding,

0 commit comments

Comments
 (0)