git-gui: Quote git path when starting another gui in a submodule

jlehmann · spearce · commit 831cc7ebb430 · 2010-01-28T15:44:41.000-08:00
In do_git_gui the path of the git executable has to be put into a
list, otherwise calling it will fail when when spaces are present
in its path.

Reported-by: Heiko Voigt &lt;hvoigt@hvoigt.net&gt;
Signed-off-by: Jens Lehmann &lt;Jens.Lehmann@web.de&gt;
Signed-off-by: Shawn O. Pearce &lt;spearce@spearce.org&gt;
diff --git a/git-gui.sh b/git-gui.sh
@@ -2059,7 +2059,7 @@ proc do_git_gui {} {
 	# -- Always start git gui through whatever we were loaded with.  This
 	#    lets us bypass using shell process on Windows systems.
 	#
-	set exe [_which git]
+	set exe [list [_which git]]
 	if {$exe eq {}} {
 		error_popup [mc "Couldn't find git gui in PATH"]
 	} else {

Original file line number	Diff line number	Diff line change
`@@ -2059,7 +2059,7 @@ proc do_git_gui {} {`
`2059`	`2059`	`# -- Always start git gui through whatever we were loaded with. This`
`2060`	`2060`	`# lets us bypass using shell process on Windows systems.`
`2061`	`2061`	`#`
`2062`		`- set exe [_which git]`
	`2062`	`+ set exe [list [_which git]]`
`2063`	`2063`	`if {$exe eq {}} {`
`2064`	`2064`	`error_popup [mc "Couldn't find git gui in PATH"]`
`2065`	`2065`	`} else {`