Skip to content

Commit 842a516

Browse files
jnarebgitster
authored andcommitted
configure.ac: improve description of NO_REGEX test
The commit 2f89522 ("regex: add regexec_buf() that can work on a non NUL-terminated string", 2016-09-21) changed description of NO_REGEX build config variable to be more neutral, and actually say that it is about support for REG_STARTEND. Change description in configure.ac to match. Change also the test message and variable name to match. The test just checks that REG_STARTEND is #defined. Issue-found-by: Ramsay Jones <[email protected]> Signed-off-by: Jakub Narębski <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent b7d36ff commit 842a516

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

configure.ac

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -835,9 +835,10 @@ AC_CHECK_TYPE([struct addrinfo],[
835835
])
836836
GIT_CONF_SUBST([NO_IPV6])
837837
#
838-
# Define NO_REGEX if you have no or inferior regex support in your C library.
839-
AC_CACHE_CHECK([whether the platform regex can handle null bytes],
840-
[ac_cv_c_excellent_regex], [
838+
# Define NO_REGEX if your C library lacks regex support with REG_STARTEND
839+
# feature.
840+
AC_CACHE_CHECK([whether the platform regex supports REG_STARTEND],
841+
[ac_cv_c_regex_with_reg_startend], [
841842
AC_EGREP_CPP(yippeeyeswehaveit,
842843
AC_LANG_PROGRAM([AC_INCLUDES_DEFAULT
843844
#include <regex.h>
@@ -846,10 +847,10 @@ AC_EGREP_CPP(yippeeyeswehaveit,
846847
yippeeyeswehaveit
847848
#endif
848849
]),
849-
[ac_cv_c_excellent_regex=yes],
850-
[ac_cv_c_excellent_regex=no])
850+
[ac_cv_c_regex_with_reg_startend=yes],
851+
[ac_cv_c_regex_with_reg_startend=no])
851852
])
852-
if test $ac_cv_c_excellent_regex = yes; then
853+
if test $ac_cv_c_regex_with_reg_startend = yes; then
853854
NO_REGEX=
854855
else
855856
NO_REGEX=YesPlease

0 commit comments

Comments
 (0)