Skip to content

Commit 8554ee1

Browse files
committed
Merge branch 'mk/mingw-winansi-ttyname-termination-fix' into maint
A potential but unlikely buffer overflow in Windows port has been fixed. * mk/mingw-winansi-ttyname-termination-fix: mingw: consider that UNICODE_STRING::Length counts bytes
2 parents 1d5cb45 + c46458e commit 8554ee1

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

compat/winansi.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -540,7 +540,7 @@ static void detect_msys_tty(int fd)
540540
buffer, sizeof(buffer) - 2, &result)))
541541
return;
542542
name = nameinfo->Name.Buffer;
543-
name[nameinfo->Name.Length] = 0;
543+
name[nameinfo->Name.Length / sizeof(*name)] = 0;
544544

545545
/*
546546
* Check if this could be a MSYS2 pty pipe ('msys-XXXX-ptyN-XX')

0 commit comments

Comments
 (0)