Skip to content

Commit 872ba00

Browse files
avargitster
authored andcommitted
Git.pm: remove redundant "use strict" from sub-package
In Perl the "use strict/warnings" pragmas are lexical, thus there's no reason to do: package Foo; use strict; package Bar; use strict; $x = 5; To satisfy the desire that the undeclared $x variable will be spotted at compile-time. It's enough to include the first "use strict". This functionally changes nothing, but makes a subsequent change where "use warnings" will be added to Git.pm less confusing and less verbose, since as with "strict" we'll only need to do that at the top of the file. Changes code initially added in a6065b5 ("Git.pm: Try to support ActiveState output pipe", 2006-06-25). Signed-off-by: Ævar Arnfjörð Bjarmason <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent ca2a4f4 commit 872ba00

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

perl/Git.pm

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1692,7 +1692,6 @@ sub DESTROY {
16921692
# Pipe implementation for ActiveState Perl.
16931693

16941694
package Git::activestate_pipe;
1695-
use strict;
16961695

16971696
sub TIEHANDLE {
16981697
my ($class, @params) = @_;

0 commit comments

Comments
 (0)