Skip to content

Commit 87f8426

Browse files
committed
Merge branch 'jk/osxkeychain-username-is-nul-terminated' into maint-2.46
The credential helper to talk to OSX keychain sometimes sent garbage bytes after the username, which has been corrected. * jk/osxkeychain-username-is-nul-terminated: credential/osxkeychain: respect NUL terminator in username
2 parents 6a562e6 + b201316 commit 87f8426

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

contrib/credential/osxkeychain/git-credential-osxkeychain.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ static void find_username_in_item(CFDictionaryRef item)
141141
username_buf,
142142
buffer_len,
143143
ENCODING)) {
144-
write_item("username", username_buf, buffer_len - 1);
144+
write_item("username", username_buf, strlen(username_buf));
145145
}
146146
free(username_buf);
147147
}

0 commit comments

Comments
 (0)