Skip to content

Commit 88db477

Browse files
committed
Error out when mingw_startup() *and* NO_UNSETENV are active
The unsetenv code has no idea to update our environ_size, therefore causing segmentation faults when environment variables are removed without compat/mingw.c's knowing (MinGW's optimized lookup would try to strcmp() against NULL in such a case). Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 45d7946 commit 88db477

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

compat/mingw.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -250,6 +250,10 @@ char *mingw_mktemp(char *template);
250250
char *mingw_getcwd(char *pointer, int len);
251251
#define getcwd mingw_getcwd
252252

253+
#ifdef NO_UNSETENV
254+
#error "NO_UNSETENV is incompatible with the MinGW startup code!"
255+
#endif
256+
253257
char *mingw_getenv(const char *name);
254258
#define getenv mingw_getenv
255259
int mingw_putenv(const char *namevalue);

0 commit comments

Comments
 (0)