Skip to content

Commit 8ba8fe0

Browse files
pcloudsgitster
authored andcommitted
rev-list: remove BISECT_SHOW_TRIED flag
Since c99f069 (bisect--helper: remove "--next-vars" option as it is now useless - 2009-04-21), this flag has always been off. Remove the flag and all related code. Signed-off-by: Nguyễn Thái Ngọc Duy <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent cb8da70 commit 8ba8fe0

File tree

2 files changed

+1
-12
lines changed

2 files changed

+1
-12
lines changed

bisect.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ extern void print_commit_list(struct commit_list *list,
1717

1818
/* bisect_show_flags flags in struct rev_list_info */
1919
#define BISECT_SHOW_ALL (1<<0)
20-
#define BISECT_SHOW_TRIED (1<<1)
2120

2221
struct rev_list_info {
2322
struct rev_info *revs;

builtin/rev-list.c

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -242,13 +242,6 @@ void print_commit_list(struct commit_list *list,
242242
}
243243
}
244244

245-
static void show_tried_revs(struct commit_list *tried)
246-
{
247-
printf("bisect_tried='");
248-
print_commit_list(tried, "%s|", "%s");
249-
printf("'\n");
250-
}
251-
252245
static void print_var_str(const char *var, const char *val)
253246
{
254247
printf("%s='%s'\n", var, val);
@@ -266,7 +259,7 @@ static int show_bisect_vars(struct rev_list_info *info, int reaches, int all)
266259
struct commit_list *tried;
267260
struct rev_info *revs = info->revs;
268261

269-
if (!revs->commits && !(flags & BISECT_SHOW_TRIED))
262+
if (!revs->commits)
270263
return 1;
271264

272265
revs->commits = filter_skipped(revs->commits, &tried,
@@ -294,9 +287,6 @@ static int show_bisect_vars(struct rev_list_info *info, int reaches, int all)
294287
printf("------\n");
295288
}
296289

297-
if (flags & BISECT_SHOW_TRIED)
298-
show_tried_revs(tried);
299-
300290
print_var_str("bisect_rev", hex);
301291
print_var_int("bisect_nr", cnt - 1);
302292
print_var_int("bisect_good", all - reaches - 1);

0 commit comments

Comments
 (0)