Skip to content

Commit 8cdef01

Browse files
szedergitster
authored andcommitted
t5541: add 'test_i18ngrep's missing filename parameter
The test 'push --no-progress silences progress but not status' runs 'test_i18ngrep' without specifying a filename parameter. This has remained unnoticed since its introduction in e304aeb (t5541: test more combinations of --progress, 2012-05-01), because that 'test_i18ngrep' is supposed to check that the given pattern is not present in its input, and of course it won't find that pattern if its input is empty (as it comes from /dev/null). This also means that this test could miss a potential breakage of 'git push --no-progress'. Signed-off-by: SZEDER Gábor <[email protected]> Reviewed-by: Jeff King <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 8279ed0 commit 8cdef01

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

t/t5541-http-push-smart.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ test_expect_success TTY 'push --no-progress silences progress but not status' '
234234
test_commit no-progress &&
235235
test_terminal git push --no-progress >output 2>&1 &&
236236
test_i18ngrep "^To http" output &&
237-
test_i18ngrep ! "^Writing objects"
237+
test_i18ngrep ! "^Writing objects" output
238238
'
239239

240240
test_expect_success 'push --progress shows progress to non-tty' '

0 commit comments

Comments
 (0)