Skip to content

Commit 9160068

Browse files
dschogitster
authored andcommitted
msvc: avoid calling access("NUL", flags)
Apparently this is not supported with Microsoft's Universal C Runtime. So let's not actually do that. Instead, just return success because we _know_ that we expect the `NUL` device to be present. Side note: it is possible to turn off the "Null device driver" and thereby disable `NUL`. Too many things are broken if this driver is disabled, therefore it is not worth bothering to try to detect its presence when `access()` is called. Signed-off-by: Johannes Schindelin <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 48bf2fa commit 9160068

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

compat/mingw.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -685,6 +685,8 @@ ssize_t mingw_write(int fd, const void *buf, size_t len)
685685
int mingw_access(const char *filename, int mode)
686686
{
687687
wchar_t wfilename[MAX_PATH];
688+
if (!strcmp("nul", filename) || !strcmp("/dev/null", filename))
689+
return 0;
688690
if (xutftowcs_path(wfilename, filename) < 0)
689691
return -1;
690692
/* X_OK is not supported by the MSVCRT version */

0 commit comments

Comments
 (0)