Fix global repository field not being cleared (#4083)

dscho · dscho · commit 921ef637dab6 · 2024-04-19T22:09:03.000+02:00
It is checked for w.r.t. global repository struct down in the callstack
in compatibility layer for MinGW before being assigned in the function
that `free()`'d it.
diff --git a/repository.c b/repository.c
@@ -54,7 +54,7 @@ static void repo_set_commondir(struct repository *repo,
 {
 	struct strbuf sb = STRBUF_INIT;
 
-	free(repo->commondir);
+	FREE_AND_NULL(repo->commondir);
 
 	if (commondir) {
 		repo->different_commondir = 1;

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ static void repo_set_commondir(struct repository *repo,`
`54`	`54`	`{`
`55`	`55`	`struct strbuf sb = STRBUF_INIT;`
`56`	`56`
`57`		`- free(repo->commondir);`
	`57`	`+ FREE_AND_NULL(repo->commondir);`
`58`	`58`
`59`	`59`	`if (commondir) {`
`60`	`60`	`repo->different_commondir = 1;`